Simplify ADC classes #495
Draft
Simplify ADC classes #495
+194
−177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an try at simplifying the common code between any ADC (and likely DAC) classes. It also provide a visible class for all support component skews to make picking the right class easier. Signed-off-by: Travis F. Collins <[email protected]>
tfcollins
force-pushed
the
tfcollins/adc-simplify
branch
from
892cf68
to
4dc4f0a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an try at simplifying the common code between any ADC (and likely DAC) classes. It also provide a visible class for all support component skews to make picking the right class easier.
With this approach, new class definitions should only contain specific pieces associate that hardware and remove a lot of boilerplate